Re: [patch]block: fix ioc locking warning
From: Tejun Heo
Date: Mon Feb 06 2012 - 12:27:12 EST
On Mon, Feb 06, 2012 at 08:58:49AM -0800, Linus Torvalds wrote:
> On Mon, Feb 6, 2012 at 8:44 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > Yeah, this seems better to me. Jens, if you're gonna amend the
> > commit, please consider collapsing the following patch into the
> > original patch too. Thanks.
> Guys, is it *really* worth it to do all these crazy games?
> How bad is it to just always use the async freeing, instead of this
> clearly very fragile crazy direct-freeing-with-serious-locking-issues
It's one wq scheduling on exit for any task which has issued an IO. I
don't think it would matter except for task fork/exit microbenchs (or
workloads which approximate to that). I'll get some measurements and
strip the optimization if it doesn't really show up.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/