Re: [PATCH] NVMe: Fix compilation on architecturs without readq/writeq

From: Hitoshi Mitake
Date: Sat Feb 04 2012 - 10:25:40 EST


On Tue, Jan 31, 2012 at 12:05, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Jan 30, 2012 at 7:03 PM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>  val |= readl(addr+4) << 32;
>
> Oops. That needs a cast to u64 before the shift, of course.
>
> Take all code I write in emails with a pinch of salt - think of it
> more as pseudo-code than something that necessarily would work as-is.
>
>                  Linus

I'll take care, thanks :)


--
Hitoshi Mitake
h.mitake@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/