Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added

From: Hillf Danton
Date: Sat Feb 04 2012 - 04:10:20 EST

2012/2/3 Michal Nazarewicz <mina86@xxxxxxxxxx>:
>>> +static inline bool migrate_async_suitable(int migratetype)
> On Fri, 03 Feb 2012 15:19:54 +0100, Hillf Danton <dhillf@xxxxxxxxx> wrote:
>> Just nitpick, since the helper is not directly related to what async
>> means,
>> how about migrate_suitable(int migrate_type) ?
> I feel current name is better suited since it says that it's OK to scan this
> block if it's an asynchronous compaction run.

The input is the migrate type of page considered, and the async is only one
of the modes that compaction should be carried out. Plus the helper is
also used in other cases where async is entirely not concerned.

That said, the naming is not clear, if not misleading.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at