Re: [PATCH] speed up /proc/pid/stat, statm

From: KAMEZAWA Hiroyuki
Date: Wed Feb 01 2012 - 03:58:16 EST


On Wed, 01 Feb 2012 06:54:42 +0100
Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:

> Le mercredi 01 fÃvrier 2012 Ã 08:55 +0900, KAMEZAWA Hiroyuki a Ãcrit :
>
> > seq_xxxx functions set m->count == m->size when it finds possible buffer overflow.
> > If m->count == m->size after ->show(), buffer will be freed and twice size buffer
> > will be re-allocated, and retry.
> >
> > If we don't set m->count == m->size here, following seq_putc() will succeed and
> > we'll see corrupted outputs.
>
> I suppose we could define a self documented helper
>
> void seq_overflow(struct seq_file *seq)
> {
> seq->count = seq->size;
> }
>

How about this ?
==