Re: [PATCH RESEND] i2c: Convert to DEFINE_PCI_DEVICE_TABLE

From: Wolfram Sang
Date: Wed Dec 28 2011 - 16:54:16 EST


On Wed, Dec 28, 2011 at 08:48:32PM +0800, Axel Lin wrote:
> Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE
> tables.
>
> Use DEFINE_PCI_DEVICE_TABLE ensures we make the pci_device_id table const
> and marked as __devinitconst.
>
> This also fixes some warnings from checkpatch:
> e.g.
> WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id
> #1096: FILE: i2c/busses/i2c-intel-mid.c:1096:
> +static struct pci_device_id intel_mid_i2c_ids[] = {
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Cool, thanks for the update!

Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature