Re: [PATCH RESEND] i2c: Convert to DEFINE_PCI_DEVICE_TABLE

From: Olof Johansson
Date: Wed Dec 28 2011 - 16:07:14 EST


On Wed, Dec 28, 2011 at 4:48 AM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE
> tables.
>
> Use DEFINE_PCI_DEVICE_TABLE ensures we make the pci_device_id table const
> and marked as __devinitconst.
>
> This also fixes some warnings from checkpatch:
> e.g.
> WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id
> #1096: FILE: i2c/busses/i2c-intel-mid.c:1096:
> +static struct pci_device_id intel_mid_i2c_ids[] = {
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> Cc: Rudolf Marek <r.marek@xxxxxxxxxxxx>
> Cc: Jean Delvare <khali@xxxxxxxxxxxx>
> Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> Cc: Olof Johansson <olof@xxxxxxxxx>
> Cc: "Mark M. Hoffman" <mhoffman@xxxxxxxxxxxxx>
> Cc: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>
> Cc: Tomoya MORINAGA <tomoya-linux@xxxxxxxxxxxxxxxxxx>
> Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> Cc: Feng Tang <feng.tang@xxxxxxxxx>
> Cc: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx

Acked-by: Olof Johansson <olof@xxxxxxxxx> [PA Semi portion]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/