Re: [PATCH] Media: video: uvc: integer overflow in uvc_ioctl_ctrl_map()

From: Laurent Pinchart
Date: Wed Nov 30 2011 - 04:14:37 EST


Hi Haogang,

On Wednesday 30 November 2011 03:28:32 Haogang Chen wrote:
> The hard limit sounds good to me.

OK.

> But if you want to centralize error handling, please make sure that "goto
> done" only frees map, but not map->menu_info in that case.

map->menu_info will be NULL, so it's safe to kfree() it.

--
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/