Re: [PATCH] RS485: fix inconsistencies in the meaning of somevariables

[Alan Cox]

> The modifications that I have proposed are very minimal, and most 
> user-space code should continue to work without any difference. Any Cris 
> user-space code will continue to work, because we didn't change the 
> behavior of the driver. For Atmel user-space code, instead, the behavior 
> of the driver changes only if flags are not set and delay variables 
> contain a value different than 0 (which, hopefully, is not a very common 
> situation). That's the reason why I preferred to not change the names of 
> the variables, even if better names would be desirable.

We have inconsistency between implementations. We don't have a change in
implementation. There isn't any way to resolve that except by fixing the
deviating implementation and doing it promptly.

With my tty hat on I'm quite happy with this patch. The sooner it is
upstream the better.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/