Re: [patch v3 14/36] Hexagon: Add signal functions

[Benjamin Herrenschmidt]

On Thu, 2011-09-08 at 20:09 -0500, Richard Kuo wrote:

> +#define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP)))
> +
> +struct sigframe {
> +	unsigned long pad[2]; /* Used to be signal tramp */
> +	struct sigcontext sc;
> +	sigset_t mask;
> +};
> +
> +struct rt_sigframe {
> +	unsigned long pad[2]; /* Used to be signal tramp */
> +	struct siginfo info;
> +	struct ucontext uc;
> +};

Why did you make two types of signal frames ? It's an unnecessary
complication... Dunno if you can still fix that (if you can still
control your ABI that is), but you should look how ppc64 uses the same
frame for RT and non-RT, avoids duplication of bugs :-)

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/