Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

[Pekka Enberg]

On 8/17/11 12:38 AM, Gábor Stefanik wrote:
> 2011/8/16 Pekka Enberg<penberg@xxxxxxxxxx>:
> > 2011/8/16 Gábor Stefanik<netrolller.3d@xxxxxxxxx>:
> > > > -
> > > > -//====================================
> > > > -// Internal variable for module
> > > > -//====================================
> > > > +/*============================================================================
> > > > +/* wb35rx.h --
> > > > +/*============================================================================
> > > I'm pretty sure this is not an accepted kernel comment style.
> > What's the problem? I think it's OK for this particular patch.
> The comments are not even valid C. The only reason why they do not
> break is that they are immediately followed by another,
> correctly-formatted (but separate) comment.
Aah,  amazing how I was able to miss that!

Akshay, I suppose you didn't compile-test the patches? Please don't
send patches like that on LKML. It's a huge waste of time for reviewers.

                                Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/