Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

From: Gábor Stefanik
Date: Tue Aug 16 2011 - 17:40:40 EST


2011/8/16 Gábor Stefanik <netrolller.3d@xxxxxxxxx>:
> 2011/8/16 Pekka Enberg <penberg@xxxxxxxxxx>:
>> 2011/8/16 Gábor Stefanik <netrolller.3d@xxxxxxxxx>:
>>>> -
>>>> -//====================================
>>>> -// Internal variable for module
>>>> -//====================================
>>>> +/*============================================================================
>>>> +/* wb35rx.h --
>>>> +/*============================================================================
>>>
>>> I'm pretty sure this is not an accepted kernel comment style.
>>
>> What's the problem? I think it's OK for this particular patch.
>>
>
> The comments are not even valid C. The only reason why they do not
> break is that they are immediately followed by another,
> correctly-formatted (but separate) comment.

BTW, my suggested style here is the following:

/*============================================================================
* wb35rx.h --
*============================================================================*/

>
> --
> Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
>



--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
èº{.nÇ+?·?®?­?+%?Ëlzwm?éb?맲æìr¸?zX§»®w¥?{ayºÊ?Ú?ë,j­¢f£¢·h??àz¹®w¥¢¸ ¢·¦j:+v?¨?wèjØm¶?ÿ¾«?êçzZ+?ù???Ý¢j"?ú!¶iO?æ¬z·?vØ^¶m§ÿðà nÆ?àþY&?