Re: [PATCH -next] sfi: sfi_acpi.c needs sysfs.h

From: Paul Gortmaker
Date: Sat Jul 30 2011 - 15:05:54 EST


On Fri, Jul 29, 2011 at 9:09 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> sfi_acpi.c needs to include linux/sysfs.h for data types.

Applied to module.h-split, thanks.

P.

>
> drivers/sfi/sfi_core.h:66: error: field 'attr' has incomplete type
> drivers/sfi/sfi_acpi.c:179: warning: 'struct kobject' declared inside parameter list
> drivers/sfi/sfi_acpi.c:179: warning: its scope is only this definition or declaration, which is probably not what you want
> drivers/sfi/sfi_acpi.c:182: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/sfi/sfi_acpi.c:182: warning: initialization from incompatible pointer type
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
>  drivers/sfi/sfi_core.h |    3 +++
>  1 file changed, 3 insertions(+)
>
> --- linux-next-20110729.orig/drivers/sfi/sfi_core.h
> +++ linux-next-20110729/drivers/sfi/sfi_core.h
> @@ -55,6 +55,9 @@
>   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
>  */
> +
> +#include <linux/sysfs.h>
> +
>  struct sfi_table_key{
>        char    *sig;
>        char    *oem_id;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/