Re: [PATCH] loop: add management interface for on-demand device allocation

From: Kay Sievers
Date: Sat Jul 30 2011 - 15:03:59 EST


On Thu, Jul 28, 2011 at 13:18, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
> On Thu, Jul 28, 2011 at 12:17, Tejun Heo <tj@xxxxxxxxxx> wrote:
>> On Tue, Jul 26, 2011 at 01:50:30PM +0200, Kay Sievers wrote:
>>> From: Kay Sievers <kay.sievers@xxxxxxxx>
>>> Subject: loop: add management interface for on-demand device allocation
>>>
>>> Loop devices today have a fixed pre-allocated number of usually 8.
>>> The number can only be changed at init time. To find a free device
>>> to use, /dev/loop%i needs to be scanned and all devices need to be
>>> opened.
>>
>> It generally looks good to me but I really hope it were split into
>> multiple patches. ÂI think it's a bit too big and doing too many
>> different things. ÂCan you please split it up?
>
> Hmm, split into what? Like splitting the loop-control stuff off? The
> rest can't really be split I guess, because all the linked lists need
> to be converted to idr at once.

Split it into 3 pieces, which I'll send now.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/