Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro indw_mmc.c

[Jaehoon Chung]

Just add Chris to CC.

Jaehoon Chung wrote:
> Hi..
> 
> this patch is right.
> 
> Acked-by : Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> 
> Regards,
> Jaehoon Chung
> 
> James Hogan wrote:
>> On 07/28/2011 12:03 PM, Shashidhar Hiremath wrote:
>>> The mask used inside this macro was assuming Buffer_Size1's[BS1's] width to be 14 bits,
>>> it is actually of 13 bits, Modified masks used in IDMAC_SET_BUFFER1_SIZE such that
>>> they use only 13 bits instead of current 14.
>>>
>>> Signed-off-by: Shashidhar Hiremath <shashidharh@xxxxxxxxxxxxxxx>
>>> ---
>>>  drivers/mmc/host/dw_mmc.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>>> index 77f0b6b..f13bb49 100644
>>> --- a/drivers/mmc/host/dw_mmc.c
>>> +++ b/drivers/mmc/host/dw_mmc.c
>>> @@ -62,7 +62,7 @@ struct idmac_desc {
>>>  
>>>  	u32		des1;	/* Buffer sizes */
>>>  #define IDMAC_SET_BUFFER1_SIZE(d, s) \
>>> -	((d)->des1 = ((d)->des1 & 0x03ffc000) | ((s) & 0x3fff))
>>> +	((d)->des1 = ((d)->des1 & 0x03ffe000) | ((s) & 0x1fff))
>>>  
>>>  	u32		des2;	/* buffer 1 physical address */
>>>  
>> Yes, according to the TRM you appear to be correct
>>
>> Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>
>>
>> Thanks
>> James
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/