Re: GMA500: ERROR: "__bad_udelay" undefined!

[Ryan Mallon]

On 25/07/11 07:37, Jesper Juhl wrote:
> Just got this when building the attached .config on x86_64 with gcc 4.6.1
> on up-to-date mainline git tree (head at
> b6844e8f64920cdee620157252169ba63afb0c89) :
>
>   ERROR: "__bad_udelay" [drivers/staging/gma500/psb_gfx.ko] undefined!
>   make[1]: *** [__modpost] Error 1
>
> I don't need gma500, so I've just disabled the driver to get around it but
> I thought some people might still like to know :)
__bad_udelay is a compile time check that constant udelays do not exceed 
a certain threshold. For x86_64 it used to be n > 20000, now it is n / 
20000 >= 1. The problem is in 
drivers/staging/gma500/psb_intel_display.c:psb_init_wait_for_vblank, 
which does udelay(20000) which under the old code would have been fine, 
but fails the new __bad_udelay check.

Possibly the udelay can just be converted to an mdelay?

~Ryan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/