Re: [PATCH 2/4] drivers/base/devtmpfs.c: correct annotation of `setup_done'

From: Arnaud Lacombe
Date: Sun Jul 24 2011 - 21:19:39 EST


Hi,

I saw that devtmpfs stuff went on through Al Viro's tree, maybe I
should have Cc: him on this ?

Thanks,
- Arnaud

On Thu, Jul 21, 2011 at 1:16 PM, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
> This fixes the following section mismatch issue:
>
> WARNING: vmlinux.o(.text+0x1192bf): Section mismatch in reference from the function devtmpfsd() to the variable .init.data:setup_done
> The function devtmpfsd() references the variable __initdata setup_done.
> This is often because devtmpfsd lacks a __initdata annotation or the annotation of setup_done is wrong.
>
> WARNING: vmlinux.o(.text+0x119342): Section mismatch in reference from the function devtmpfsd() to the variable .init.data:setup_done
> The function devtmpfsd() references the variable __initdata setup_done.
> This is often because devtmpfsd lacks a __initdata annotation or the annotation of setup_done is wrong.
>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
> Signed-off-by: Arnaud Lacombe <lacombar@xxxxxxxxx>
> ---
>  drivers/base/devtmpfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
> index 6d678c9..38e6464 100644
> --- a/drivers/base/devtmpfs.c
> +++ b/drivers/base/devtmpfs.c
> @@ -376,7 +376,7 @@ int devtmpfs_mount(const char *mntdir)
>        return err;
>  }
>
> -static __initdata DECLARE_COMPLETION(setup_done);
> +static DECLARE_COMPLETION(setup_done);
>
>  static int handle(const char *name, mode_t mode, struct device *dev)
>  {
> --
> 1.7.6.153.g78432
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/