Re: [PATCH v2] regulator: tps65910: Add missing breaks inswitch/case

From: Liam Girdwood
Date: Fri Jul 22 2011 - 06:48:14 EST


On Sun, 2011-07-10 at 20:09 +0900, Mark Brown wrote:
> On Sun, Jul 10, 2011 at 06:41:22PM +0800, Axel Lin wrote:
> > Also add a default case in tps65910_list_voltage_dcdc to silence
> > 'volt' may be used uninitialized in this function warning.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
>
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> though for the default case I'd suggest also adding a BUG() as if that
> happens either the driver is confused or the core is making up
> regulators for us.
> --

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/