Re: RFC: Boiler plate functions for ida / idr allocation?

From: Tejun Heo
Date: Thu Jul 21 2011 - 04:19:57 EST

On Thu, Jul 21, 2011 at 05:07:36PM +0930, Rusty Russell wrote:
> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Subject: ida: Simplified functions for id allocation.
> The current hyper-optimized functions are overkill if you simply want
> to allocate an id for a device. Create versions which use an internal
> lock.
> Thanks to Tejun for feedback. Feel free to delete the #ifdef TEST
> code.
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> static struct kmem_cache *idr_layer_cache;
> +static DEFINE_SPINLOCK(simple_ida);

I think the name is a bit confusing. Maybe simple_ida_lock is better?
Other than that,

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

I guess this is best routed through -mm?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at