Re: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.
From: Olof Johansson
Date: Tue Jul 19 2011 - 19:53:46 EST
On Tue, Jul 19, 2011 at 4:50 PM, Andrew Chew <AChew@xxxxxxxxxx> wrote:
>> Although that said, since many of the USB properties are
>> and determined by system characterization, they aren't generally
>> applicable to all Tegra devices. As such, should those values be moved
>> into tegra-seaboard.dts instead? Perhaps tegra20.dtsi should specify
>> the default values that the driver currently uses if not supplied with
>> platform data though... I think the Seaboard values are the defaults,
>> which still would make this patch obsolete.
> Turns out the ones I put in tegra20.dtsi are NOT the defaults. The defaults are in arch/arm/mach-tegra/usb_phy.c, contained in "utmip_defaults".
> I think I'm going to put those utmip_defaults stuff into tegra20.dtsi, and override them in tegra-seaboard.dts. How's that sound?
Sounds good to me, or if they for sure will need tuning on all boards
and there are no "safe" settings, leave them out from the generic
> And since there are defaults specified in tegra20.dtsi, does it really make sense to also have default values assigned in ehci-tegra.c (for when a property is not present)? I worry that the information is now duplicated. If those properties aren't present, then someone's mucked with the tegra20.dtsi ehci properties.
Once all platforms are cut over to devicetree-only, that can be the
case. Until that happens, there will be need for settings in the C
code too. Is Nvidia switching to device trees for android/fastboot?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/