RE: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.

From: Stephen Warren
Date: Tue Jul 19 2011 - 19:04:38 EST


achew@xxxxxxxxxx wrote at Tuesday, July 19, 2011 4:47 PM:
> From: Andrew Chew <achew@xxxxxxxxxx>
>
> Signed-off-by: Andrew Chew <achew@xxxxxxxxxx>

Removing status="disabled" from tegra20.dtsi makes this patch obsolete.

Although that said, since many of the USB properties are board-specific
and determined by system characterization, they aren't generally
applicable to all Tegra devices. As such, should those values be moved
into tegra-seaboard.dts instead? Perhaps tegra20.dtsi should specify
the default values that the driver currently uses if not supplied with
platform data though... I think the Seaboard values are the defaults,
which still would make this patch obsolete.

> ---
> arch/arm/boot/dts/tegra-seaboard.dts | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts
> index 5a99b4c..c5a1b71 100644
> --- a/arch/arm/boot/dts/tegra-seaboard.dts
> +++ b/arch/arm/boot/dts/tegra-seaboard.dts
> @@ -31,4 +31,16 @@
> sdhci@c8000600 {
> status = "ok";
> };
> +
> + ehci@c5000000 {
> + status = "ok";
> + };
> +
> + ehci@c5004000 {
> + status = "ok";
> + };
> +
> + ehci@c5008000 {
> + status = "ok";
> + };
> };
> --
> 1.7.6

--
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/