Re: [PATCH 1/3] perf: add context field to perf_event

From: Joerg Roedel
Date: Tue Jul 12 2011 - 06:24:51 EST


On Tue, Jul 12, 2011 at 01:07:25PM +0300, Avi Kivity wrote:
> On 07/12/2011 01:03 PM, Joerg Roedel wrote:

>> Ingo made perf-integration a merge-requirement for LWP. It is not really
>> well-suited for being integrated into perf because the design goal was
>> easy and efficient self-profiling of tasks (like you stated). So
>> integrating it into perf causes some pain. But lets see how it works
>> out.
>
> I don't think it's workable. Having do_mmap() called in the task's
> context can change how it works.

According to Ingo that is already done at other places in the kernel and
should not be an issue.

> And the task being able to kill/modify the profile, and not able to
> use LWP for itself, is a show stopper IMO.

I agree, that is a problem we have no solution for so far.

Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/