Re: [PATCH] s3c2410_udc: fix custom UDC command handling

From: Felipe Balbi
Date: Mon Jun 20 2011 - 11:36:57 EST


On Mon, Jun 20, 2011 at 05:20:02PM +0200, Skacore Systems wrote:
> I've been exactly following
> To create a patch for a single file, it is often sufficient to do:
> SRCTREE= linux-2.6
> MYFILE= drivers/net/mydriver.c
> cp $MYFILE $MYFILE.orig
> vi $MYFILE # make your change
> cd ..
> diff -up $SRCTREE/$MYFILE{.orig,} > /tmp/patch
> And that's what I've done. What do you think is wrong with it ???

patch should be in 'p1' format to start with, not 'p0'!!

Your commit log shouldn't include your "regards" or anything like that,
or that will go into the git history.

> Subject: [PATCH] s3c2410_udc: fix custom UDC command handling

this should be something like:

[PATCH] usb: gadget: s3c2410_udc: fix custom UDC command handling

we generally put the subsystem on the subject to help maintainers
filter patches related to them.

> There is a bug in Samsung's UDC driver, which is completely disabling
> the USB device when a custom UDC command is used.
> Following patch seems to get the right?behavior (e.g. enabling pull-up
> instead of disabling then Vcc is applied).

"seems to get the right behavior" makes me wonder if you really tested
this properly. Either it fixes the problem, or it doesn't. Have you
tried with other possible commands to see if also helps ?

> Also I'm not in mailing list so please CC me.

this would go to commit log, shouldn't be here.

> Greetingz,
> Vilo

this shouldn't be here either.

> Signed-off-by: Viliam Mateicka <viliam.mateicka@xxxxxxxxx>

there should be a tear line here. (---)

> --- drivers/usb/gadget/s3c2410_udc.c.orig ? ? ? 2011-05-19
> 06:06:34.000000000 +0200

this line break is bogus.

you could have looked at any mailing list archive for properly formatted
patches, but instead you chose to be unpolite with the persons who are
giving you a "service" free of charge.

At [1] you can find an example of a proper patch



Attachment: signature.asc
Description: Digital signature