Re: [PATCH] s3c2410_udc: fix custom UDC command handling

From: Skacore Systems
Date: Mon Jun 20 2011 - 11:20:25 EST


I've been exactly following
http://www.kernel.org/doc/Documentation/SubmittingPatches:

To create a patch for a single file, it is often sufficient to do:

SRCTREE= linux-2.6
MYFILE= drivers/net/mydriver.c

cd $SRCTREE
cp $MYFILE $MYFILE.orig
vi $MYFILE # make your change
cd ..
diff -up $SRCTREE/$MYFILE{.orig,} > /tmp/patch

And that's what I've done. What do you think is wrong with it ???

Vilo


On Mon, Jun 20, 2011 at 5:15 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
>
> On Mon, Jun 20, 2011 at 11:07:51AM -0400, Alan Stern wrote:
>> On Mon, 20 Jun 2011, Viliam Mateicka wrote:
>>
>> > So, will somebody at least react/reply (or just fix) ?
>>
>> Have some patience.  You did not address your email message to either
>> of the driver's authors or to the current Gadget maintainer.  Also,
>> David Brownell is deceased and Greg KH is on vacation.
>
> besides, the patch formatting is wrong. That was noted before and the
> reply was less than acceptably polite, so unless the patch comes
> Perfect(TM), I'm not looking into it.
>
> --
> balbi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/