Re: [PATCH V4] tty/serial: add support for Xilinx PS UART

From: Grant Likely
Date: Fri May 06 2011 - 12:42:00 EST


On Fri, May 6, 2011 at 6:23 AM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
>> I don't agree with this change. NO_IRQ for microblaze, arm and other is -1. BTW:
>> For ppc is 0. Using NO_IRQ seems to me reasonable.
>
> 0 means "no interrupt".
>
> The old mis-use of -1 is an old mostly ARM specific ugly that ahould be
> going away not getting repeated further. If Microblaze is using this hack
> then it needs to stop.

This will be easier for microblaze when I finish the irq_domain work.
There are patches on the list, but they need to be reworked before
they are ready for mainline consumption.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/