Re: [PATCH V4] tty/serial: add support for Xilinx PS UART

From: Alan Cox
Date: Fri May 06 2011 - 08:22:51 EST


> I don't agree with this change. NO_IRQ for microblaze, arm and other is -1. BTW:
> For ppc is 0. Using NO_IRQ seems to me reasonable.

0 means "no interrupt".

The old mis-use of -1 is an old mostly ARM specific ugly that ahould be
going away not getting repeated further. If Microblaze is using this hack
then it needs to stop.

NO_IRQ was *purposefully* removed from general consumption a long time
ago for a good reason (historically it was an IDE driver internal define
certain people borrowed)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/