Re: [PATCH] export kernel call get_task_comm().

[David Rientjes]

On Fri, 22 Apr 2011, james_p_freyensee@xxxxxxxxxxxxxxx wrote:

> From: J Freyensee <james_p_freyensee@xxxxxxxxxxxxxxx>
> 
> This allows drivers who call this function to be compiled modularly.
> Otherwise, a driver who is interested in this type of functionality
> has to implement their own get_task_comm() call, causing code
> duplication in the Linux source tree.
> 
> Signed-off-by: J Freyensee <james_p_freyensee@xxxxxxxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

I still suggest that we implement finer-grained protection for tsk->comm 
through get_task_comm(), though, because it's going to be difficult to 
know whether task_lock(tsk) is held in all contexts we'll want to call it; 
task_lock(tsk) is used to protect many members of task_struct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/