Re: [PATCH 12/13] regulator: check name in initialization of max8925

[Mark Brown]

On Wed, Apr 13, 2011 at 10:51:03PM +0800, Haojian Zhuang wrote:
> Check name in initialization of max8925 regulator driver.

> +		if (!strcmp(ri->desc.name, pdata->constraints.name))
> +			break;

This isn't a good change - the whole point of the name in the
constraints is that it allows the user to assign an arbatrary string
which is useful for the board.  The driver should never be looking
inside the constraints at all, the core will apply the constraints for
you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/