Re: [PATCH]drivers:regulator:change the dev_dbg in the probe function

From: Mark Brown
Date: Sat Apr 16 2011 - 13:54:55 EST


On Sat, Apr 16, 2011 at 11:42:23PM +0800, wanlong.gao@xxxxxxxxx wrote:

Please ensure that you use subject lines for your patch which fit in
with the style of other changes to the subsystem.

> change the function name string to "%s".

You should also explain why a change is being made, not what the change
is (we can see that from the patch). In this case what you're doing is
making this debug statement be consistent with the style of the rest of
the file.

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/