Re: [PATCHv5 1/3] ARM: Translate delay.S into (mostly) C

[Saravana Kannan]

On 04/06/2011 01:49 AM, Mattias Wallin wrote:
> On 04/06/2011 01:56 AM, Stephen Boyd wrote:
> > +void __udelay(unsigned long usecs)
> > +{
> > + __const_udelay(usecs * ((2199023*HZ)>>11));
> This will overflow if HZ=1000.
> If I remember correct I fixed it like this:
> __const_udelay(usecs * ((2199023UL*HZ)>>11));
>
> /Mattias Wallin

Mattias,

Isn't this a big in the existing code too? I would prefer not combining 
that with this patch series. That bug should be fixed before/after this 
patch series. Not as part of it.

I would vote for after this patch series since this patch series has 
been trying to get in for quite a while now.

-Saravana

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/