Re: [PATCH] usb_wwan: fix build error in play_delayed.

From: Greg KH
Date: Tue Mar 22 2011 - 12:46:39 EST


On Tue, Mar 22, 2011 at 07:05:55AM +0100, Eric Dumazet wrote:
> Le mardi 22 mars 2011 Ã 12:29 +0800, Tao Ma a Ãcrit :
> > From: Tao Ma <boyu.mt@xxxxxxxxxx>
> >
> > There is a build error in today's linus tree.
> > drivers/usb/serial/usb_wwan.c: In function âplay_delayedâ:
> > drivers/usb/serial/usb_wwan.c:702: error: âstruct dev_pm_infoâ has no member named âusage_countâ
> > The reason is that usage_count is wrapped with macro CONFIG_PM_RUNTIME
> > now in dev_pm_info.
> >
> > So use the corresponding pm_runtime_get_noresume instead.
> >
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
> > Signed-off-by: Tao Ma <boyu.mt@xxxxxxxxxx>
> > ---
> > drivers/usb/serial/usb_wwan.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
> > index a65ddd5..5858ce4 100644
> > --- a/drivers/usb/serial/usb_wwan.c
> > +++ b/drivers/usb/serial/usb_wwan.c
> > @@ -699,7 +699,7 @@ static void play_delayed(struct usb_serial_port *port)
> > do {
> > unbusy_queued_urb(urb, portdata);
> > //extremely dirty
> > - atomic_dec(&port->serial->interface->dev.power.usage_count);
> > + pm_runtime_get_noresume(&port->serial->interface->dev);
> > } while ((urb = usb_get_from_anchor(&portdata->delayed)));
> > break;
> > }
>
> Oh well, thats the third time this patch is sent

Yes, sorry, been busy with other stuff, this will get fixed soon, I have
enough copies of it in my queue :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/