Re: [PATCH] uinput strnlen bugfix

[Aristeu Rozanski]

On Sun, Feb 06, 2011 at 05:57:19PM +0100, David Herrmann wrote:
> On Sun, Feb 6, 2011 at 5:55 PM, Aristeu Rozanski <aris@xxxxxxxxxxxxxxxxx> wrote:
> > and where's the patch? :^)
> >
> > --
> > Aristeu
> >
> 
> ah, embarrasing.., sorry.
> I attached the patchfile.
> 
> David

> --- old/drivers/input/misc/uinput.c	2011-02-06 17:40:24.951454656 +0100
> +++ new/drivers/input/misc/uinput.c	2011-02-06 17:41:16.747454654 +0100
> @@ -372,8 +372,8 @@
>  
>  	udev->ff_effects_max = user_dev->ff_effects_max;
>  
> -	size = strnlen(user_dev->name, UINPUT_MAX_NAME_SIZE) + 1;
> -	if (!size) {
> +	size = strnlen(user_dev->name, UINPUT_MAX_NAME_SIZE);
> +	if (!size++) {
>  		retval = -EINVAL;
>  		goto exit;
>  	}
Acked-by: Aristeu Rozanski <aris@xxxxxxxxx>

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/