Re: [PATCH] uinput strnlen bugfix

From: David Herrmann
Date: Sun Feb 06 2011 - 11:57:23 EST


On Sun, Feb 6, 2011 at 5:55 PM, Aristeu Rozanski <aris@xxxxxxxxxxxxxxxxx> wrote:
> and where's the patch? :^)
>
> --
> Aristeu
>

ah, embarrasing.., sorry.
I attached the patchfile.

David
--- old/drivers/input/misc/uinput.c 2011-02-06 17:40:24.951454656 +0100
+++ new/drivers/input/misc/uinput.c 2011-02-06 17:41:16.747454654 +0100
@@ -372,8 +372,8 @@

udev->ff_effects_max = user_dev->ff_effects_max;

- size = strnlen(user_dev->name, UINPUT_MAX_NAME_SIZE) + 1;
- if (!size) {
+ size = strnlen(user_dev->name, UINPUT_MAX_NAME_SIZE);
+ if (!size++) {
retval = -EINVAL;
goto exit;
}