Re: [PATCH] vsprintf: Neaten %pK kptr_restrict, save a bit of codespace

[Andrew Morton]

On Wed, 19 Jan 2011 15:11:02 -0800
Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Wed, 2011-01-19 at 14:50 -0800, Andrew Morton wrote:
> > On Thu, 13 Jan 2011 12:21:12 -0800
> > Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > If kptr restrictions are on, just set the passed pointer to NULL.
> > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> []
> > > +		if (!((kptr_restrict == 0) ||
> > > +		      (kptr_restrict == 1 &&
> > > +		       has_capability_noaudit(current, CAP_SYSLOG))))
> > > +			ptr = NULL;
> > > +		break;
> > This hurts my brain.   Does it work?
> 
> Some say mentally challenging puzzles help deter/delay
> onset of cognitive decline/Alzheimer's.  See: www.dakim.com
> 
> A mentally less challenging perhaps cleaner form is:
> 
> 		if (kptr_restrict == 0)
> 			break;
> 		if (kptr_restrict == 1 &&
> 		    has_capability_noaudit(current, CAP_SYSLOG))
> 			break;
> 		ptr = NULL;
> 		break;
> 
> Your choice. ;)

That wasn't the bit which hurt.

You still haven't told me if it works.  How thoroughly was it tested?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/