Re: [PATCH] Westbridge software module, fixes errors reported bycheckpatch.pl

From: Greg KH
Date: Tue Jan 18 2011 - 23:31:12 EST


On Mon, Jan 17, 2011 at 03:59:09PM -0800, Sutharsan Ramamoorthy wrote:
> From: Sutharsan Ramamoorthy <srmt@xxxxxxxxxxx>
>
> This patch fixes errors in westbridge device controller driver in the
> staging tree reported by checkpatch.pl. File containing EXPORT_SYMBOL()
> macros for all the API's exported by the westbridge software has been
> removed. EXPORT_SYMBOL() macro's are added after the functions being
> exported. This patch also fixes some function prototype definitions and
> removes new typdefs.

Care to split this into two patches? Every patch should only do one
thing at a time.

> +struct cyasdevice {
>         /* Handle to the Antioch device */
>         cy_as_device_handle            dev_handle;
>         /* Handle to the HAL */
>         cy_as_hal_device_tag            hal_tag;
>         spinlock_t      common_lock;
>         unsigned long flags;
> -} cyasdevice;
> +} ;

What's with the extra space here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/