Re: [RFC] arm: Defer lookup of machine_type and vet of atags to setup.c

From: Grant Likely
Date: Tue Jan 11 2011 - 00:22:12 EST


On Mon, Jan 10, 2011 at 8:19 PM, Nicolas Pitre <nico@xxxxxxxxxxx> wrote:
> On Mon, 10 Jan 2011, Grant Likely wrote:
>
>> Since the debug macros no longer depend on the machine type
>> information, both the machine type lookup and the atags vetting can be
>> deferred to setup_arch() in setup.c which simplifies the code
>> somewhat.
>>
>> This patch removes both __machine_type_lookup and __vet_atags() from
>> head.S.  The atags vetting is moved to setup_arch().  machine_type
>> lookup is already called from setup_machine() in addition to where it
>> was called from head.S.
>
> While at it, you could also remove the code for __lookup_machine_type,
> lookup_machine_type and __error_a, replacing that with a C
> implementation living in setup.c instead.  If this code is not called
> from head.S anymore, there is no reason to keep it there any longer.

Certainly. I'll draft that up as a separate patch and post it tomorrow.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/