Re: [PATCH -v3 1/4] pci, usb: Make usb handoff func all take baseremapping

From: Benjamin Herrenschmidt
Date: Tue Jan 11 2011 - 00:22:02 EST


On Mon, 2011-01-10 at 17:20 -0800, Yinghai Lu wrote:
>
> for early access, can not use udelay yet, it will take some one.
> Also msleep will cause crash, because it needs scheduler there.

Right, and that's for such special cases (hopefully rare) that we have
system_state... Much better than your function pointers I reckon.

We could even wrap it into a safe_delay() function or whatever (in fact
why not make msleep() itself safe ? It's not like it was timing critical
code :-)

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/