Re: [PATCH v2] tg3: fix return value check in tg3_read_vpd()

From: David Miller
Date: Fri Dec 31 2010 - 15:31:00 EST


From: David Sterba <dsterba@xxxxxxx>
Date: Wed, 29 Dec 2010 14:40:31 +0100

> Besides -ETIMEDOUT and -EINTR, pci_read_vpd may return other error
> values like -ENODEV or -EINVAL which are ignored due to the buggy
> check, but the data are not read from VPD anyway and this is checked
> subsequently with at most 3 needless loop iterations. This does not
> show up as a runtime bug.
>
> CC: Matt Carlson <mcarlson@xxxxxxxxxxxx>
> CC: Michael Chan <mchan@xxxxxxxxxxxx>
> Signed-off-by: David Sterba <dsterba@xxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/