Re: [PATCH] XFS: Compare, don't assign in ASSERT() inxfs_trans_unreserve_and_mod_sb()

From: Dave Chinner
Date: Mon Dec 27 2010 - 09:14:15 EST


On Sat, Dec 25, 2010 at 09:14:53PM +0100, Jesper Juhl wrote:
> Hi,
>
> In fs/xfs/xfs_trans.c::xfs_trans_unreserve_and_mod_sb() at the out: label
> we have this:
> ASSERT(error = 0);
> I believe a comparison was intended, not an assignment. If I'm right, the
> patch below fixes that up.

Already fixed in this patch pending for 2.6.38:

http://git.kernel.org/?p=linux/kernel/git/dgc/xfsdev.git;a=commitdiff;h=831ef3cf682a1f9d8fc7c16dace55137751c0410

Cheers,

Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/