[PATCH] XFS: Compare, don't assign in ASSERT() inxfs_trans_unreserve_and_mod_sb()

From: Jesper Juhl
Date: Sat Dec 25 2010 - 15:24:53 EST


Hi,

In fs/xfs/xfs_trans.c::xfs_trans_unreserve_and_mod_sb() at the out: label
we have this:
ASSERT(error = 0);
I believe a comparison was intended, not an assignment. If I'm right, the
patch below fixes that up.

Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
---
xfs_trans.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

compile tested only.

diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
index f6d956b..0e312b9 100644
--- a/fs/xfs/xfs_trans.c
+++ b/fs/xfs/xfs_trans.c
@@ -1137,7 +1137,7 @@ out_undo_fdblocks:
if (blkdelta)
xfs_icsb_modify_counters(mp, XFS_SBS_FDBLOCKS, -blkdelta, rsvd);
out:
- ASSERT(error = 0);
+ ASSERT(error == 0);
return;
}


--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/