Re: [2/8, v5] NUMA Hotplug Emulator: Add node hotplug emulation

[David Rientjes]

On Tue, 30 Nov 2010, Shaohui Zheng wrote:

> We have two memory hotplug interfaces here:
> add_node: add a new NUMA node
> probe: add memory section
> 
> so puting add_node to node/add_node and puting probe to memory/probe should make sense. 
> it is similar with sysfs hierarchy.
> 
> if we want to move the add_node to mem_hotplug/add_node, I'd prefer to put the probe
> interface to mem_hotplug/probe since they are also related to memory hotplug.
> 
> I will include this change in next patchset.
> 

No, please don't move the 'probe' trigger to debugfs; hotadding memory 
should not depend on CONFIG_DEBUG_FS.  Node hotplug emulation _is_ a 
debugging function and can therefore be defined in debugfs as I did but 
with a s/hotplug/mem_hotplug change that Greg suggested.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/