Re: [8/8, v5] NUMA Hotplug Emulator: documentation

From: Valdis . Kletnieks
Date: Mon Nov 29 2010 - 13:20:25 EST


On Mon, 29 Nov 2010 17:17:58 +0800, shaohui.zheng@xxxxxxxxx said:
> From: Shaohui Zheng <shaohui.zheng@xxxxxxxxx>
>
> add a text file Documentation/x86/x86_64/numa_hotplug_emulator.txt
> to explain the usage for the hotplug emulator.

Can you renumber this to 1/8 if you resubmit it? It helps code review if you
already know what it's *intended* to do beforehand. It also helps drinking
from the lkml firehose if you can read 0/N and 1/N and know if it's something
you want to review, otherwise you read 0/N, have to go find N/N, read that,
then go back and delete 1/N through N-1/N.

(Sometimes, the 0/N cover isn't enough - reading the documentation actually
fills in enough blanks to make you go "Wow, this *is* applicable to something
I'm working on...")

Attachment: pgp00000.pgp
Description: PGP signature