Re: [PATCH v2 3/3] Prevent promotion of page in madvise_dontneed

[Minchan Kim]

On Mon, Nov 29, 2010 at 1:28 PM, Rik van Riel <riel@xxxxxxxxxx> wrote:
> On 11/28/2010 10:02 AM, Minchan Kim wrote:
>>
>> Now zap_pte_range alwayas promotes pages which are pte_young&&
>> !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED,
>> it's unnecessary since the page wouldn't use any more.
>>
>> If the page is sharred by other processes and it's real working set
>
> This line seems to be superfluous, I don't see any special
> treatment for this case in the code.

I should remove the lines.
It's my fault.

>
>> Signed-off-by: Minchan Kim<minchan.kim@xxxxxxxxx>
>> Cc: Rik van Riel<riel@xxxxxxxxxx>
>> Cc: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx>
>> Cc: Johannes Weiner<hannes@xxxxxxxxxxx>
>> Cc: Nick Piggin<npiggin@xxxxxxxxx>
>> Cc: Mel Gorman<mel@xxxxxxxxx>
>> Cc: Wu Fengguang<fengguang.wu@xxxxxxxxx>
>
> The patch itself looks good to me.
>
> Acked-by: Rik van Riel <riel@xxxxxxxxxx>

Thanks, Rik.
-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/