Re: [PATCH] Repalce strncmp by memcmp

[Dmitry Torokhov]

On Mon, Nov 29, 2010 at 06:11:21AM +0300, Pavel Vasilyev wrote:
> On 29.11.2010 05:29, Ming Lei wrote:
> > Hi,
> >
> > 2010/11/29 Pavel Vasilyev <pavel@xxxxxxxxxxx>:
> >>    This patch replace all strncmp(a, b, c) by  memcmp(a, b, c).
> >>
> >> I test on x86_64 (AMD Opteron 285).
> > In fact, memcmp doesn't handle case of tail of string, so
> > it is not safe to replace strncmp with memcmp
> >
> #include <stdio.h>
> #include <errno.h>
> 
> int main() {
> 
>    char *STR = "XXXX\0";
>    char *XXX = "XXXX";

Try comparing:

"XXXX\0YYYY" and
"XXXX\0ZZZZ"

and observe the difference.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/