Re: [PATCH 5/9] x86: Replace apic->apicid_to_node() with ->numa_cpu_node()

From: Pekka Enberg
Date: Thu Nov 11 2010 - 06:37:19 EST


On Thu, Nov 11, 2010 at 1:02 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> apic->apicid_to_node() is 32bit specific apic operation which
> determines NUMA node for a CPU.  Depending on the APIC implementation,
> it can be easier to determine NUMA node from either physical or
> logical apicid.  Currently, ->apicid_to_node() takes @logical_apicid
> and calls hard_smp_processor_id() if the physical apicid is needed.
>
> This prevents NUMA mapping from being queried from a different CPU,
> which in turn makes it impossible to initialize NUMA mapping before
> SMP bringup.
>
> This patch replaces apic->apicid_to_node() with ->numa_cpu_node()
> which takes @cpu, from which both logical and physical apicids can
> easily be determined.  While at it, drop duplicate implementations
> from bigsmp_32 and summit_32, and use the default.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>

Acked-by: Pekka Enberg <penberg@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/