Re: [PATCH] ARM: imx: Add some core definitions for MX53

[Grant Likely]

On Wed, Oct 27, 2010 at 11:09:21AM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Oct 27, 2010 at 09:29:59AM +0100, Grant Likely wrote:
> > > ---
> > >  arch/arm/plat-mxc/include/mach/iomux-mx53.h |  301 +++++++++++++++++++
> > >  arch/arm/plat-mxc/include/mach/mx53.h       |  433 +++++++++++++++++++++++++++
> > 
> > Hi Dinh.
> > 
> > In general, these definitions should not be added until they are
> > actually needed by driver code.
> ack.
> 
> > Also, from my understanding, the mx53 is very similar to the mx51.
> > If I'm correct, then they should be sharing the same set of #defines.
> Note, I asked for a seperate header file.  See
> http://thread.gmane.org/gmane.linux.kernel/1051001/focus=1051352

For the record, I disagree with that approach.  The approach I would
take is for the imx53 code to use the imx51 defines by default, and to
only define imx53 variants where there are differences.  Otherwise the
code to support imx53 has to be completely divergent from imx51
because the defines are different symbols.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/