Re: [PATCH] ARM: imx: Add some core definitions for MX53

[Uwe Kleine-König]

Hello,

On Wed, Oct 27, 2010 at 09:29:59AM +0100, Grant Likely wrote:
> > ---
> >  arch/arm/plat-mxc/include/mach/iomux-mx53.h |  301 +++++++++++++++++++
> >  arch/arm/plat-mxc/include/mach/mx53.h       |  433 +++++++++++++++++++++++++++
> 
> Hi Dinh.
> 
> In general, these definitions should not be added until they are
> actually needed by driver code.
ack.

> Also, from my understanding, the mx53 is very similar to the mx51.
> If I'm correct, then they should be sharing the same set of #defines.
Note, I asked for a seperate header file.  See
http://thread.gmane.org/gmane.linux.kernel/1051001/focus=1051352

> What is the diff between *mx51.h and *mx53.h?
Just from a quick look at least some base addresses are different.
(e.g. MX51_DEBUG_BASE_ADDRESS = 0x60000000, MX53_DEBUG_BASE_ADDRESS =
0x40000000; SPBA0, AIPS1 and AIPS2 differ, too)

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/