Re: [PATCH v3 4/6] x86/PCI: allocate space from the end of a region,not the beginning

From: H. Peter Anvin
Date: Wed Oct 13 2010 - 17:28:59 EST


On 10/13/2010 09:15 AM, Bjorn Helgaas wrote:
>
> +#define ALIGN_DOWN(x, a) ((x) & ~(a - 1))
> - resource_size_t start = res->start;
> + resource_size_t start = ALIGN_DOWN(res->end - size + 1, align);
>

Use round_down() here instead of inventing yet another macro?

In all other respects:

Reviewed-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/