Re: [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining

[Andi Kleen]

On Tue, Oct 12, 2010 at 02:23:15PM +0000, Penttilä Mika wrote:
> > >>  		bad_page(page);
> > >>  		return 1;
> > >>  	}
> > >
> > > And of course PAGE_FLAGS_CHECK_AT_FREE should include
> > > pahehwpoisononfree this to be effective
> > 
> > It is of course (__PG_HWPOISON_ON_FREE)
> > 
> Yes but it's not included in PAGE_FLAGS_CHECK_AT_FREE, if  I'm not missing something

#ifdef CONFIG_HWPOISON_ON_FREE
PAGEFLAG(HWPoisonOnFree, hwpoison_on_free)
TESTSCFLAG(HWPoisonOnFree, hwpoison_on_free)
#define __PG_HWPOISON_ON_FREE (1UL << PG_hwpoison_on_free)
#else
PAGEFLAG_FALSE(HWPoisonOnFree)
SETPAGEFLAG_NOOP(HWPoisonOnFree)
#define __PG_HWPOISON_ON_FREE 0
#endif

...

#define PAGE_FLAGS_CHECK_AT_FREE \
        (1 << PG_lru     | 1 << PG_locked    | \
         1 << PG_private | 1 << PG_private_2 | \
         1 << PG_buddy   | 1 << PG_writeback | 1 << PG_reserved | \
         1 << PG_slab    | 1 << PG_swapcache | 1 << PG_active | \
         1 << PG_unevictable | __PG_MLOCKED | __PG_HWPOISON | \
         __PG_HWPOISON_ON_FREE)


-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/