RE: [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining

From: Penttilä Mika
Date: Tue Oct 12 2010 - 10:23:27 EST


>
> >> --- a/mm/page_alloc.c
> >> +++ b/mm/page_alloc.c
> >> @@ -564,6 +564,8 @@ static inline int free_pages_check(struct page
> *page)
> >> (page->mapping != NULL) |
> >> (atomic_read(&page->_count) != 0) |
> >> (page->flags & PAGE_FLAGS_CHECK_AT_FREE))) {
> >> + if (PageHWPoisonOnFree(page))
> >> + hwpoison_page_on_free(page);
> >
> > hwpoison_page_on_free() seems to be undefined when
> > CONFIG_HWPOISON_ON_FREE is not defined.
>
> The optimizer takes care of that.
>
> >
> >> bad_page(page);
> >> return 1;
> >> }
> >
> > And of course PAGE_FLAGS_CHECK_AT_FREE should include
> > pahehwpoisononfree this to be effective
>
> It is of course (__PG_HWPOISON_ON_FREE)
>
Yes but it's not included in PAGE_FLAGS_CHECK_AT_FREE, if I'm not missing something

--Mika


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/