Re: [PATCH v12 06/17] Use callback to deal with skb_release_data()specially.

From: Eric Dumazet
Date: Mon Oct 11 2010 - 11:42:26 EST


Le lundi 11 octobre 2010 Ã 08:27 -0700, David Miller a Ãcrit :
> From: "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx>
> Date: Mon, 11 Oct 2010 15:06:05 +0800
>
> > That's to avoid the new cache miss caused by using destructor_arg in data path
> > like skb_release_data().
> > That's based on the comment from Eric Dumazet on v7 patches.
>
> Thanks for the explanation.

Anyway, frags[] must be the last field of "struct skb_shared_info"
since commit fed66381 (net: pskb_expand_head() optimization)

It seems Xin worked on a quite old tree.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/